vmcheck: Honor TESTS= #692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Mar 20, 2017
tests/vmcheck/multitest.py
Outdated
| matched_tests = [] | ||
| unmatched_tests = [] | ||
| for test in tests: | ||
| testbn = os.path.basename(test) |
There was a problem hiding this comment.
Can we use _strip_test() for this? With test.sh, the actual syntax for TESTS excludes the leading "test-" and trailing ".sh" (just like the test.sh in projectatomic/atomic). We should probably accept the same syntax here too.
|
Whoops, good catch! |
|
I think for the local testing scenario, it probably makes more sense to use |
Minor regression from the multitest reimplementation, but it's really handy for the "debug and fix a test" case.
cgwalters
force-pushed
the
vmcheck-multitest-honor-TESTS
branch
from
803e5da to
12b4000
Compare
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor regression from the multitest reimplementation, but it's really handy for
the "debug and fix a test" case.